lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <91b04197-fc92-84f9-8c5a-0399a922ccd0@infradead.org> Date: Tue, 17 Apr 2018 23:30:37 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Hans de Goede <hdegoede@...hat.com>, USB list <linux-usb@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Cc: Fengguang Wu <fengguang.wu@...el.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andy Shevchenko <andy.shevchenko@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com> Subject: Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error On 04/17/18 02:01, Hans de Goede wrote: > Hi, > > On 17-04-18 07:14, Randy Dunlap wrote: >> From: Randy Dunlap <rdunlap@...radead.org> >> >> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB >> Makefile does not currently build drivers/usb/common/ (where >> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify >> the USB Makefile to always descend into drivers/usb/common/ >> to build its configured targets. >> >> Fixes these build errors: >> >> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! >> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! >> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! >> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! >> >> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 >> driver Kconfig entry, but this would build more code in >> drivers/usb/common/ than is necessary. > > Ah, that variant of fixing this got posted yesterday and I acked that, > but I agree that this version is better. That was my first patch version, but I didn't like it. However, I missed that patch. If I had seen it, I wouldn't have posted this patch. > Greg, what is your take on this fix? > > Chanwoo Choi, please wait with merging the fix from yesterday until > we've a decision which fix to use. > > Regards, > > Hans > > > >> >> Reported-by: Fengguang Wu <fengguang.wu@...el.com> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org> >> Cc: MyungJoo Ham <myungjoo.ham@...sung.com> >> Cc: Chanwoo Choi <cw00.choi@...sung.com> >> Cc: Hans de Goede <hdegoede@...hat.com> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> >> Cc: Andy Shevchenko <andy.shevchenko@...il.com> >> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com> >> Cc: linux-usb@...r.kernel.org >> --- >> drivers/usb/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- lnx-417-rc1.orig/drivers/usb/Makefile >> +++ lnx-417-rc1/drivers/usb/Makefile >> @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA) += chipidea/ >> obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ >> obj-$(CONFIG_USB_GADGET) += gadget/ >> -obj-$(CONFIG_USB_COMMON) += common/ >> +obj-y += common/ >> obj-$(CONFIG_USBIP_CORE) += usbip/ >> >> > -- ~Randy
Powered by blists - more mailing lists