lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180422132033.GA15242@kroah.com> Date: Sun, 22 Apr 2018 15:20:33 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Hans de Goede <hdegoede@...hat.com> Cc: Randy Dunlap <rdunlap@...radead.org>, USB list <linux-usb@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Fengguang Wu <fengguang.wu@...el.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com> Subject: Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error On Tue, Apr 17, 2018 at 11:01:41AM +0200, Hans de Goede wrote: > Hi, > > On 17-04-18 07:14, Randy Dunlap wrote: > > From: Randy Dunlap <rdunlap@...radead.org> > > > > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB > > Makefile does not currently build drivers/usb/common/ (where > > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify > > the USB Makefile to always descend into drivers/usb/common/ > > to build its configured targets. > > > > Fixes these build errors: > > > > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! > > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! > > > > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 > > driver Kconfig entry, but this would build more code in > > drivers/usb/common/ than is necessary. > > Ah, that variant of fixing this got posted yesterday and I acked that, > but I agree that this version is better. > > Greg, what is your take on this fix? I'll take the patch from Arnd for this. thanks, greg k-h
Powered by blists - more mailing lists