linux-kernel - Re: [PATCH] [media] include/media: fix missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <ebce8e36-9125-aecb-b0d1-87f068646e67@samsung.com>
Date:   Wed, 18 Apr 2018 17:20:17 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Kyungmin Park <kyungmin.park@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] include/media: fix missing | operator when
 setting cfg

On 04/18/2018 05:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however
> this is not being used and cfg is being re-assigned.  I believe the
> assignment operator should actually be instead the |= operator.
> 
> Detected by CoverityScan, CID#1467987 ("Unused value")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks for the patch.

Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>