linux-kernel - Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A518FF77-554C-40E0-8656-5BEFA57C7A8E@vmware.com>
Date:   Wed, 18 Apr 2018 17:54:21 +0000
From:   Nadav Amit <namit@...are.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        Xavier Deguillard <xdeguillard@...are.com>,
        pv-drivers <pv-drivers@...are.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Gil Kupfer <gilkup@...il.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "ldu@...hat.com" <ldu@...hat.com>,
        Oleksandr Natalenko <oleksandr@...hat.com>
Subject: Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is
 off

Oleksandr Natalenko <oleksandr@...hat.com> wrote:

> Hello.
> 
> On Fri, Mar 23, 2018 at 9:42 AM, Oleksandr Natalenko
> <oleksandr@...hat.com> wrote:
>>> Actually, rechecking the bug description, I might have rushed. The bug that
>>> I encountered is related to the vunmap() but it is only caused when batching
>>> is off, while the bug you reported has batching on.
>>> 
>>> It seems that your sources support batching but do not include b91f108a3d54
>>> (“VMware balloon: Treat init like reset”), which I think would have solved
>>> the problem. I don’t see a mainline kernel that supports batching and does
>>> not have this patch, so it would be helpful to see the exact module that you
>>> use.
>> 
>> Correct. The hash is d7568c130d0d0ff1fc5b364fc879b91f108a3d54, actually, though.
>> Yes, we miss this commit in our code base, but also we've already
>> provided a test kernel
>> with this commit included to the customer. Unfortunately, we have no answer yet.
> 
> At least for one customer I can confirm that the kernel built with
> both d7568c130 and the proposed patch fixes the issue.

Greg,

Can you commit please this patch? Preferably for 4.17?

There is one minor mistake in the commit message - this patch fixes
f220a80f0c2e and not as written. Please let me know if you want a v3 or can
amend it while committing.

Thanks,
Nadav