linux-kernel - Re: [PATCH 1/2] iio: adc128s052: allow driver to be matched using ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180421165441.0c64415d@archlinux>
Date:   Sat, 21 Apr 2018 16:54:41 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Javier Arteaga <javier@...tex.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Dan O'Donovan <dan@...tex.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc128s052: allow driver to be matched using
 ACPI

On Thu, 19 Apr 2018 14:20:35 +0100
Javier Arteaga <javier@...tex.com> wrote:

> From: Dan O'Donovan <dan@...tex.com>
> 
> Allow driver to be matched by compatible string in
> ACPI device properties.
> 
> Signed-off-by: Dan O'Donovan <dan@...tex.com>
Hi Javier,

I don't really see the connection between the change in here
and what the description says...

If you are probing from ACPI then there is no need to ensure
a valid of table is supplied (even if we aren't building with OF)
which is what I think this patch is trying to do...

Jonathan

> ---
>  drivers/iio/adc/ti-adc128s052.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index 7cf39b3e2416..56ec04d1c68f 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -202,7 +202,7 @@ MODULE_DEVICE_TABLE(spi, adc128_id);
>  static struct spi_driver adc128_driver = {
>  	.driver = {
>  		.name = "adc128s052",
> -		.of_match_table = of_match_ptr(adc128_of_match),
> +		.of_match_table = adc128_of_match,
>  	},
>  	.probe = adc128_probe,
>  	.remove = adc128_remove,