linux-kernel - Re: [RFC PATCH] fs: introduce ST_HUGE flag and set it to tmpfs and hugetlbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Apr 2018 12:05:12 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Yang Shi <yang.shi@...ux.alibaba.com>, viro@...iv.linux.org.uk,
        nyc@...omorphy.com, mike.kravetz@...cle.com,
        kirill.shutemov@...ux.intel.com, hughd@...gle.com,
        akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] fs: introduce ST_HUGE flag and set it to tmpfs and
 hugetlbfs

On Thu, Apr 19, 2018 at 01:28:10AM -0700, Christoph Hellwig wrote:
> On Wed, Apr 18, 2018 at 11:18:25AM -0700, Yang Shi wrote:
> > Yes, thanks for the suggestion. I did think about it before I went with the
> > new flag. Not like hugetlb, THP will *not* guarantee huge page is used all
> > the time, it may fallback to regular 4K page or may get split. I'm not sure
> > how the applications use f_bsize field, it might break existing applications
> > and the value might be abused by applications to have counter optimization.
> > So, IMHO, a new flag may sound safer.
> 
> But st_blksize isn't the block size, that is why I suggested it.  It is
> the preferred I/O size, and various file systems can report way
> larger values than the block size already.

I agree. This looks like a better fit.

-- 
 Kirill A. Shutemov