linux-kernel - Re: [PATCH 2/5] powerpc: rtas: clean up time handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 10:32:47 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Paul Mackerras <paulus@...ba.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] powerpc: rtas: clean up time handling

On Mon, Apr 23, 2018 at 10:10 AM, Arnd Bergmann <arnd@...db.de> wrote:

> @@ -307,17 +307,17 @@ static ssize_t ppc_rtas_poweron_write(struct file *file,
>                 const char __user *buf, size_t count, loff_t *ppos)
>  {
>         struct rtc_time tm;
> -       unsigned long nowtime;
> +       time64_t nowtime;
>         int error = parse_number(buf, count, &nowtime);
>         if (error)
>                 return error;
>
>         power_on_time = nowtime; /* save the time */
>
> -       to_tm(nowtime, &tm);
> +       rtc_time64_to_tm(nowtime, 0, &tm);
>

Here was the other obvious typo: I had originally changed this to
'time64_to_tm()', which has slightly different calling conventions to
'rtc_time64_to_tm()', and messed it up when I changed it back
after it turned out I needed to select RTC_LIB anyway.

v2 coming.

        Arnd