linux-kernel - Re: [PATCH] perf tools: set kernel end address properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423135221.GC3254@kernel.org>
Date:   Mon, 23 Apr 2018 10:52:21 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com
Subject: Re: [PATCH] perf tools: set kernel end address properly

Em Fri, Apr 20, 2018 at 06:23:58PM -0500, Kim Phillips escreveu:
> On Fri, 20 Apr 2018 08:59:15 +0900
> Namhyung Kim <namhyung@...nel.org> wrote:
> 
> > The map_groups__fixup_end() was called to set end addresses of kernel
> > map and module maps.  But now machine__create_modules() is set the end
> > address of modules properly, the only remaining piece is the kernel map.
> > We can set it with adjacent module's address directly instead of calling
> > the map_groups__fixup_end().  If there's no module after the kernel map,
> > the end address will be ~0ULL.
> > 
> > Since it also changes the start address of the kernel map, it needs to
> > re-insert the map to the kmaps in order to keep a correct ordering.  Kim
> > reported that it caused problems on ARM64.
> > 
> > Reported-by: Kim Phillips <kim.phillips@....com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > ---
> 
> Acked-by: Kim Phillips <kim.phillips@....com>

So as you actually seem to have tested this, I'm taking this as a
Tested-by instead, to better reflect what you did, ok?

- Arnaldo