lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1524625806-23133-1-git-send-email-shunyong.yang@hxt-semitech.com> Date: Wed, 25 Apr 2018 11:10:06 +0800 From: Shunyong Yang <shunyong.yang@...-semitech.com> To: <ard.biesheuvel@...aro.org> CC: <linux-efi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Shunyong Yang <shunyong.yang@...-semitech.com>, Joey Zheng <yu.zheng@...-semitech.com> Subject: [PATCH] efi/capsule-loader: Don't output reset log when header flags is not set It means firmware attempts to immediately process or launch the capsule when flags in capsule header is not set. Moreover, reset is not needed in this case. Current code will output log to indicate reset. This patch adds a branch to avoid reset log output when the flags is not set. Cc: Joey Zheng <yu.zheng@...-semitech.com> Signed-off-by: Shunyong Yang <shunyong.yang@...-semitech.com> --- drivers/firmware/efi/capsule-loader.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c index e456f4602df1..a63b8e5bde23 100644 --- a/drivers/firmware/efi/capsule-loader.c +++ b/drivers/firmware/efi/capsule-loader.c @@ -134,10 +134,15 @@ static ssize_t efi_capsule_submit_update(struct capsule_info *cap_info) /* Indicate capsule binary uploading is done */ cap_info->index = NO_FURTHER_WRITE_ACTION; - pr_info("Successfully upload capsule file with reboot type '%s'\n", - !cap_info->reset_type ? "RESET_COLD" : - cap_info->reset_type == 1 ? "RESET_WARM" : - "RESET_SHUTDOWN"); + + if (cap_info->header.flags) + pr_info("Successfully upload capsule file with reboot type '%s'\n", + !cap_info->reset_type ? "RESET_COLD" : + cap_info->reset_type == 1 ? "RESET_WARM" : + "RESET_SHUTDOWN"); + else + pr_info("Successfully upload, process and launch capsule file\n"); + return 0; } -- 1.8.3.1
Powered by blists - more mailing lists