lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Apr 2018 23:09:15 +0200
From:   Andrew Lunn <>
To:     Alexandre Belloni <>
Cc:     "David S . Miller" <>,
        Allan Nielsen <>,,,
        Thomas Petazzoni <>,
        Florian Fainelli <>,,,,
Subject: Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch

> +/* Checks if the net_device instance given to us originate from our driver. */
> +static bool ocelot_netdevice_dev_check(const struct net_device *dev)
> +{
> +	return dev->netdev_ops == &ocelot_port_netdev_ops;
> +}

This is probably O.K. now, but when you add support for controlling
the switch over PCIe, i think it breaks. A board could have two

It might be possible to do something with dev->parent. All ports of a
switch should have the same parent.


Powered by blists - more mailing lists