lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180426210915.GE23481@lunn.ch> Date: Thu, 26 Apr 2018 23:09:15 +0200 From: Andrew Lunn <andrew@...n.ch> To: Alexandre Belloni <alexandre.belloni@...tlin.com> Cc: "David S . Miller" <davem@...emloft.net>, Allan Nielsen <Allan.Nielsen@...rosemi.com>, razvan.stefanescu@....com, po.liu@....com, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org Subject: Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support > +/* Checks if the net_device instance given to us originate from our driver. */ > +static bool ocelot_netdevice_dev_check(const struct net_device *dev) > +{ > + return dev->netdev_ops == &ocelot_port_netdev_ops; > +} This is probably O.K. now, but when you add support for controlling the switch over PCIe, i think it breaks. A board could have two switches... It might be possible to do something with dev->parent. All ports of a switch should have the same parent. Andrew
Powered by blists - more mailing lists