linux-kernel - Re: [PATCH] firmware: dmi: Add access to the SKU ID string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Apr 2018 13:01:10 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Vinod Koul <vinod.koul@...el.com>, Simon Glass <sjg@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        C Shapiro <shapiroc@...omium.org>,
        Aaron Durbin <adurbin@...omium.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jonathan Corbet <corbet@....net>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alex Hung <alex.hung@...onical.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        sayli karnik <karniksayli1995@...il.com>,
        Sagar Dharia <sdharia@...eaurora.org>
Subject: Re: [PATCH] firmware: dmi: Add access to the SKU ID string

On jeu., 2018-04-26 at 15:03 +0530, Vinod Koul wrote:
> On Wed, Apr 25, 2018 at 03:17:37PM -0600, Simon Glass wrote:
> > 
> > Hi Vinod,
> > 
> > On 24 April 2018 at 20:51, Vinod Koul <vinod.koul@...el.com> wrote:
> > > 
> > > On Tue, Apr 24, 2018 at 03:11:11PM -0600, Simon Glass wrote:
> > > > 
> > > > This is used in some systems from user space for determining the identity
> > > > of the device.
> > > > 
> > > > Expose this as a file so that that user-space tools don't need to read
> > > > from /sys/firmware/dmi/tables/DMI
> > > 
> > > sysfs is an ABI and needs to be documented, I don't see that in this patch,
> > > pls add.
> > 
> > Thanks for taking a look. The only mention of the dmi/id I can find is
> > in Kconfig:
> 
> Sorry I should have been explicit. All sysfs entries are ABI to userspace.
> So they are documented in kernel and the meaning of files should not
> typically get modfied over time.
> Please read Documentation/ABI/README
> 
> For DMI, quick grep told me you should add to
> Documentation/ABI/testing/sysfs-firmware-dmi-tables

No. This is a different interface to user-space (binary tables, instead
of already decoded, selected attributes.)

There is currently no formal documentation of the
/sys/devices/virtual/dmi/id contents, so there's no file Simon can
modify to mention product_sku. Instead, documentation of the whole
directory should be added in a separate patch.

-- 
Jean Delvare
SUSE L3 Support