linux-kernel - Re: [PATCH v1] device property: Get rid of union aliasing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0huZAZjRDSkgR+z8XqLShoyy24arevD3oiwn7GPHRid+g@mail.gmail.com>
Date:   Thu, 26 Apr 2018 15:05:05 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-efi@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH v1] device property: Get rid of union aliasing

On Thu, Apr 26, 2018 at 2:54 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Thu, Apr 26, 2018 at 01:23:56PM +0300, Andy Shevchenko wrote:
>> The commit
>>
>>   318a19718261 ("device property: refactor built-in properties support")
>>
>> went way too far and brought a union aliasing. Partially revert it here
>> to get rid of union aliasing.
>
> What is "union aliasing"?  And why is it bad?
>
>> Note, Apple properties support is still utilizing this trick.
>
> So you are breaking something now?
>
> What exactly is this fixing?

A device properties framework change that went in through my tree.

I'll take care of this, but I agree that the commit log is not
particularly useful.

Cheers,
Rafael