linux-kernel - Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36dd1547-38a3-0658-b25f-fbb41d6fe265@metafoo.de>
Date:   Thu, 26 Apr 2018 18:26:23 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Moritz Fischer <mdf@...nel.org>, linux-kernel@...r.kernel.org
Cc:     dmaengine@...r.kernel.org, vinod.koul@...el.com,
        dan.j.williams@...el.com
Subject: Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Use devm_request_irq() instead of request_irq() to request the IRQ.
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>
> ---
> 
> Hi Lars,
> 
> was there a specific reason not to use devm_request_irq() ?

Yes, it is wrong :)

This reorders the sequence in the remove() function. We really need to free
the IRQ at the point in the sequence where it is at the moment. We need to
call tasklet_kill() after the free_irq() function has been called, otherwise
the tasklet can be re-scheduled and we might end up with a use after free.

But also if we disable the clock to the core before the IRQ is freed we
might end up trying to access the register map while the clock is off and
then never get a response and block the AXI bus.

This is all very very unlikely to ever happen, but still I'd like to have
correct code.

> 
> Cheers,
> 
> Moritz
> 
> ---
>  drivers/dma/dma-axi-dmac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..75ccedaa96d2 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_unregister_device;
>  
> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> -		dev_name(&pdev->dev), dmac);
> +	ret = devm_request_irq(&pdev->dev, dmac->irq,
> +			       axi_dmac_interrupt_handler, 0,
> +			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
>  
> @@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev)
>  	struct axi_dmac *dmac = platform_get_drvdata(pdev);
>  
>  	of_dma_controller_free(pdev->dev.of_node);
> -	free_irq(dmac->irq, dmac);
>  	tasklet_kill(&dmac->chan.vchan.task);
>  	dma_async_device_unregister(&dmac->dma_dev);
>  	clk_disable_unprepare(dmac->clk);
>