linux-kernel - Re: [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea8d2aaf-c627-9c6e-55f3-57acbfd09498@metafoo.de>
Date:   Thu, 26 Apr 2018 18:27:00 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Moritz Fischer <mdf@...nel.org>, linux-kernel@...r.kernel.org
Cc:     dmaengine@...r.kernel.org, vinod.koul@...el.com,
        dan.j.williams@...el.com
Subject: Re: [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks.

> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 75ccedaa96d2..2bd195532882 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  		goto err_unregister_device;
>  
>  	ret = devm_request_irq(&pdev->dev, dmac->irq,
> -			       axi_dmac_interrupt_handler, 0,
> +			       axi_dmac_interrupt_handler, IRQF_SHARED,
>  			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
>