| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Apr 2018 18:45:53 +0000
From: Tom Talpey <ttalpey@...rosoft.com>
To: Long Li <longli@...rosoft.com>, Steve French <sfrench@...ba.org>,
"linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
"samba-technical@...ts.samba.org" <samba-technical@...ts.samba.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [PATCH v5] cifs: Allocate validate negotiation request through
kmalloc
> -----Original Message-----
> From: linux-cifs-owner@...r.kernel.org <linux-cifs-owner@...r.kernel.org> On
> Behalf Of Long Li
> Sent: Wednesday, April 25, 2018 2:30 PM
> To: Steve French <sfrench@...ba.org>; linux-cifs@...r.kernel.org; samba-
> technical@...ts.samba.org; linux-kernel@...r.kernel.org; linux-
> rdma@...r.kernel.org
> Cc: Long Li <longli@...rosoft.com>
> Subject: [PATCH v5] cifs: Allocate validate negotiation request through kmalloc
>
> From: Long Li <longli@...rosoft.com>
>
> The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will
> return an invalid DMA address for a buffer on stack. Even worse, this
> incorrect address can't be detected by ib_dma_mapping_error. Sending data
> from this address to hardware will not fail, but the remote peer will get
> junk data.
>
> Fix this by allocating the request on the heap in smb3_validate_negotiate.
>
Looks good.
Reviewed-By: Tom Talpey <ttalpey@...rosoft.com>
Powered by blists - more mailing lists