linux-kernel - Re: [PATCH] libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180426184643.GL1911913@devbig577.frc2.facebook.com>
Date:   Thu, 26 Apr 2018 11:46:43 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kevin Shanahan <kevin@...nahan.id.au>
Subject: Re: [PATCH] libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV
 SSD

On Tue, Apr 24, 2018 at 11:19:07AM +0200, Hans de Goede wrote:
> Kevin Shanahan reports the following repeating errors when using LPM,
> causing long delays accessing the disk:
> 
>   Apr 23 10:21:43 link kernel: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x50000 action 0x6 frozen
>   Apr 23 10:21:43 link kernel: ata1: SError: { PHYRdyChg CommWake }
>   Apr 23 10:21:43 link kernel: ata1.00: failed command: WRITE DMA
>   Apr 23 10:21:43 link kernel: ata1.00: cmd ca/00:08:60:5d:cd/00:00:00:00:00/e1 tag 9 dma 4096 out
>                                         res 50/01:01:01:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
>   Apr 23 10:21:43 link kernel: ata1.00: status: { DRDY }
>   Apr 23 10:21:43 link kernel: ata1.00: error: { AMNF }
>   Apr 23 10:21:43 link kernel: ata1: hard resetting link
>   Apr 23 10:21:43 link kernel: ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
>   Apr 23 10:21:43 link kernel: ata1.00: configured for UDMA/133
>   Apr 23 10:21:43 link kernel: ata1: EH complete
> 
> These go away when switching from med_power_with_dipm to medium_power.
> 
> This is somewhat weird as the PM830 datasheet explicitly mentions DIPM
> being supported and the idle power-consumption is specified with DIPM
> enabled.
> 
> There are many OEM customized firmware versions for the PM830, so for now
> lets assume this is firmware version specific and blacklist LPM based on
> the firmware version.
> 
> Cc: Kevin Shanahan <kevin@...nahan.id.au>
> Reported-by: Kevin Shanahan <kevin@...nahan.id.au>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>

Applied to libata/for-4.17-fixes.

Thanks.

-- 
tejun