| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJWu+or9GJwkDK9+842YbobG3=xVW-PgqS=uE5P2xFbDhmqxEQ@mail.gmail.com>
Date: Fri, 27 Apr 2018 09:14:30 -0700
From: Joel Fernandes <joelaf@...gle.com>
To: Paul McKenney <paulmck@...ux.vnet.ibm.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Steven Rostedt <rostedt@...dmis.org>,
Peter Zilstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Tom Zanussi <tom.zanussi@...ux.intel.com>,
Namhyung Kim <namhyung@...nel.org>,
Thomas Glexiner <tglx@...utronix.de>,
Boqun Feng <boqun.feng@...il.com>,
Frederic Weisbecker <fweisbec@...il.com>,
Randy Dunlap <rdunlap@...radead.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
Fenguang Wu <fengguang.wu@...el.com>,
Baohong Liu <baohong.liu@...el.com>,
Vedang Patel <vedang.patel@...el.com>,
"Cc: Android Kernel" <kernel-team@...roid.com>
Subject: Re: [PATCH RFC] tracepoint: Introduce tracepoint callbacks executing
with preempt on
Hi Paul,
On Fri, Apr 27, 2018 at 8:57 AM, Paul E. McKenney
<paulmck@...ux.vnet.ibm.com> wrote:
> On Thu, Apr 26, 2018 at 09:26:56PM -0700, Joel Fernandes wrote:
>> In recent tests with IRQ on/off tracepoints, a large performance
>> overhead ~10% is noticed when running hackbench. This is root caused to
>> calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the
>> tracepoint code. Following a long discussion on the list [1] about this,
>> we concluded that srcu is a better alternative for use during rcu idle.
>> Although it does involve extra barriers, its lighter than the sched-rcu
>> version which has to do additional RCU calls to notify RCU idle about
>> entry into RCU sections.
>>
>> In this patch, we change the underlying implementation of the
>> trace_*_rcuidle API to use SRCU. This has shown to improve performance
>> alot for the high frequency irq enable/disable tracepoints.
>>
>> In the future, we can add a new may_sleep API which can use this
>> infrastructure for callbacks that actually can sleep which will support
>> Mathieu's usecase of blocking probes.
>>
>> Test: Tested idle and preempt/irq tracepoints.
>
> Looks good overall! One question and a few comments below.
>
> Thanx, Paul
>
>> [1] https://patchwork.kernel.org/patch/10344297/
>>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Peter Zilstra <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Cc: Tom Zanussi <tom.zanussi@...ux.intel.com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Thomas Glexiner <tglx@...utronix.de>
>> Cc: Boqun Feng <boqun.feng@...il.com>
>> Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>
>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>> Cc: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Masami Hiramatsu <mhiramat@...nel.org>
>> Cc: Fenguang Wu <fengguang.wu@...el.com>
>> Cc: Baohong Liu <baohong.liu@...el.com>
>> Cc: Vedang Patel <vedang.patel@...el.com>
>> Cc: kernel-team@...roid.com
>> Signed-off-by: Joel Fernandes <joelaf@...gle.com>
>> ---
>> include/linux/tracepoint.h | 37 +++++++++++++++++++++++++++++--------
>> kernel/tracepoint.c | 10 +++++++++-
>> 2 files changed, 38 insertions(+), 9 deletions(-)
>>
>> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
>> index c94f466d57ef..a1c1987de423 100644
>> --- a/include/linux/tracepoint.h
>> +++ b/include/linux/tracepoint.h
>> @@ -15,6 +15,7 @@
>> */
>>
>> #include <linux/smp.h>
>> +#include <linux/srcu.h>
>> #include <linux/errno.h>
>> #include <linux/types.h>
>> #include <linux/cpumask.h>
>> @@ -33,6 +34,8 @@ struct trace_eval_map {
>>
>> #define TRACEPOINT_DEFAULT_PRIO 10
>>
>> +extern struct srcu_struct tracepoint_srcu;
>> +
>> extern int
>> tracepoint_probe_register(struct tracepoint *tp, void *probe, void *data);
>> extern int
>> @@ -77,6 +80,7 @@ int unregister_tracepoint_module_notifier(struct notifier_block *nb)
>> */
>> static inline void tracepoint_synchronize_unregister(void)
>> {
>> + synchronize_srcu(&tracepoint_srcu);
>> synchronize_sched();
>> }
>>
>> @@ -129,18 +133,26 @@ extern void syscall_unregfunc(void);
>> * as "(void *, void)". The DECLARE_TRACE_NOARGS() will pass in just
>> * "void *data", where as the DECLARE_TRACE() will pass in "void *data, proto".
>> */
>> -#define __DO_TRACE(tp, proto, args, cond, rcucheck) \
>> +#define __DO_TRACE(tp, proto, args, cond, preempt_on) \
>> do { \
>> struct tracepoint_func *it_func_ptr; \
>> void *it_func; \
>> void *__data; \
>> + int __maybe_unused idx = 0; \
>> \
>> if (!(cond)) \
>> return; \
>> - if (rcucheck) \
>> - rcu_irq_enter_irqson(); \
>> - rcu_read_lock_sched_notrace(); \
>> - it_func_ptr = rcu_dereference_sched((tp)->funcs); \
>> + if (preempt_on) { \
>> + WARN_ON_ONCE(in_nmi()); /* no srcu from nmi */ \
>
> Very good on this check, thank you!
Sure thing :-)
>
>> + idx = srcu_read_lock(&tracepoint_srcu); \
>
> Hmmm... Do I need to create a _notrace variant of srcu_read_lock()
> and srcu_read_unlock()?
That shouldn't be needed. For the rcu_read_lock_sched case, there is a
preempt_disable which needs to be a notrace, but for the srcu one,
since we don't do that, I think it should be fine.
Thanks!
- Joel
Powered by blists - more mailing lists