linux-kernel - Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5af7b6a6-8a40-880d-3346-8c90bd700957@ideasonboard.com>
Date:   Fri, 27 Apr 2018 17:22:06 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     linux-renesas-soc@...r.kernel.org,
        Takeshi Kihara <takeshi.kihara.df@...esas.com>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output

Hi Laurent,

On 26/04/18 22:21, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@...esas.com>
>>
>> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
>> the HDMI connector.
>>
>> Based on a similar patches of the the Salvator-X board
>> on the R8A7796 SoC device tree
>> by Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Thanks, collected.

> 
> How about adding the VGA output too ? I think you can add both VGA and HDMI in 
> a single patch that enables display in one go for the board. Same comment for 
> the Salvator-XS.

I believe the VGA output is handled by the salvator-common.dtsi, and thus
doesn't need to be included in this patch.

> 
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@...esas.com>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
>> ---
>>  .../boot/dts/renesas/r8a77965-salvator-x.dts    | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
>> a2b8fb20fef8..11e8d43e9e11 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -31,3 +31,20 @@
>>  	clock-names = "du.0", "du.1", "du.3", "lvds.0",
>>  		      "dclkin.0", "dclkin.1", "dclkin.3";
>>  };
>> +
>> +&hdmi0 {
>> +	status = "okay";
>> +
>> +	ports {
>> +		port@1 {
>> +			reg = <1>;
>> +			rcar_dw_hdmi0_out: endpoint {
>> +				remote-endpoint = <&hdmi0_con>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&hdmi0_con {
>> +	remote-endpoint = <&rcar_dw_hdmi0_out>;
>> +};
>