lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Apr 2018 11:26:21 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Moritz Fischer <mdf@...nel.org>, linux-kernel@...r.kernel.org Cc: corbet@....net, linux-fpga@...r.kernel.org, atull@...nel.org, linux-doc@...r.kernel.org, michal.simek@...inx.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 2/4] fpga: manager: change api, don't use drvdata On 04/26/2018 06:26 PM, Moritz Fischer wrote: > From: Alan Tull <atull@...nel.org> > > Change fpga_mgr_register to not set or use drvdata. This supports > the case where a PCIe device has more than one manager. > > Add fpga_mgr_create/free functions. Change fpga_mgr_register and > fpga_mgr_unregister functions to take the mgr struct as their only > parameter. > > struct fpga_manager *fpga_mgr_create(struct device *dev, > const char *name, > const struct fpga_manager_ops *mops, > void *priv); > void fpga_mgr_free(struct fpga_manager *mgr); > int fpga_mgr_register(struct fpga_manager *mgr); > void fpga_mgr_unregister(struct fpga_manager *mgr); > > Update the drivers that call fpga_mgr_register with the new API. Apologies for chiming in so late, this commit does not make it clear that fpga_mgr_unregister() now also free the 'mgr' argument by calling fpga_mgr_free(), this is kind of detail, but an API should make that clear IMHO. Thanks -- Florian
Powered by blists - more mailing lists