linux-kernel - Re: [PATCH v8 2/4] arm64: tlbflush: Introduce __flush_tlb_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180427102900.4e63lo4eksk23vtn@armageddon.cambridge.arm.com>
Date:   Fri, 27 Apr 2018 11:29:01 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Chintan Pandya <cpandya@...eaurora.org>
Cc:     will.deacon@....com, mark.rutland@....com, toshi.kani@....com,
        linux-arch@...r.kernel.org, arnd@...db.de,
        ard.biesheuvel@...aro.org, marc.zyngier@....com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        kristina.martsenko@....com, takahiro.akashi@...aro.org,
        james.morse@....com, tglx@...utronix.de, akpm@...ux-foundation.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 2/4] arm64: tlbflush: Introduce
 __flush_tlb_kernel_pgtable

On Tue, Apr 03, 2018 at 01:30:44PM +0530, Chintan Pandya wrote:
> Add an interface to invalidate intermediate page tables
> from TLB for kernel.
> 
> Signed-off-by: Chintan Pandya <cpandya@...eaurora.org>
> ---
>  arch/arm64/include/asm/tlbflush.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> index 9e82dd7..6a4816d 100644
> --- a/arch/arm64/include/asm/tlbflush.h
> +++ b/arch/arm64/include/asm/tlbflush.h
> @@ -209,6 +209,12 @@ static inline void __flush_tlb_pgtable(struct mm_struct *mm,
>  	dsb(ish);
>  }
>  
> +static inline void __flush_tlb_kernel_pgtable(unsigned long addr)
> +{
> +	addr >>= 12;
> +	__tlbi(vaae1is, addr);
> +	dsb(ish);
> +}
>  #endif

Please use __TLBI_VADDR here as it does some additional masking.

-- 
Catalin