linux-kernel - Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180430184751.574550cc@bbrezillon>
Date:   Mon, 30 Apr 2018 18:47:51 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-mtd@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as
 chipselect

On Mon, 30 Apr 2018 18:45:06 +0200
Bartosz Golaszewski <brgl@...ev.pl> wrote:

> 2018-04-30 12:09 GMT+02:00 Boris Brezillon <boris.brezillon@...tlin.com>:
> > Hi Bartosz,
> >
> > On Mon, 30 Apr 2018 10:24:41 +0200
> > Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> >> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >>
> >> We have the 'ti,davinci-chipselect' property in the device tree, but
> >> when using platform data the driver silently uses the id field of
> >> struct platform_device as the chipselect. This is confusing and we
> >> almost broke the nand support again recently after converting the
> >> platform to common clock framework (which changed the device id in the
> >> clock lookup - the problem is gone now that we no longer acquire the
> >> clock in the nand driver.
> >>
> >> This series adds a new field to davinci-nand platform data, then makes
> >> all board use it and finally modifies the two drivers that make use of
> >> it.
> >>
> >> Bartosz Golaszewski (12):
> >>   mtd: nand: davinci: store the core chipselect number in platform data
> >
> > Raw NAND related patches (that is, everything that is not onenand or
> > SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that,
> > I'm fine with the patch series, just let me know how you want to have it
> > merged (through the MTD tree or the davinci tree).
> >
> > Thanks,
> >
> > Boris
> 
> I think Sekhar could pick all those patches up for 4.18.

Okay, then I'd need an immutable branch containing these changes.

> 
> Sekhar - do you want me to resend the series with the commit message
> changed as requested by Boris, or can you fix it when applying the
> series?
> 
> Best regards,
> Bartosz Golaszewski