linux-kernel - Re: [PATCH v6 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180502145642.GA21162@codeaurora.org>
Date:   Wed, 2 May 2018 08:56:42 -0600
From:   Lina Iyer <ilina@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Evan Green <evgreen@...omium.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 02/10] dt-bindings: introduce RPMH RSC bindings for
 Qualcomm SoCs

On Tue, May 01 2018 at 17:45 -0600, Doug Anderson wrote:
>Hi,
>
>On Thu, Apr 19, 2018 at 3:16 PM, Lina Iyer <ilina@...eaurora.org> wrote:
>> +TCS-OFFSET: 0xD00
>> +
>> +       apps_rsc: rsc@...e000 {
>
>This label is wrong in two ways:
>
>1. I believe it's supposed to be the first reg listed, so 179c0000
>
>2. There's only 3 0's at the end.
>
>Thus, it should be:
>
>apps_rsc: rsc@...c0000
>
Ok. Will fix.

I did not hear back on this idea. Does this binding work for everyone
else?

Thanks,
Lina

>> +               label = "apps_rsc";
>> +               compatible = "qcom,rpmh-rsc";
>> +               reg = <0x179c0000 0x10000>, <0x179d0000 0x10000>,
>> +                     <0x179e0000 0x10000>, <0xd00 0>;
>> +               reg-names = "drv-0", "drv-1", "drv-2", "tcs-offset";
>> +               interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>> +               qcom,drv-id = <2>;
>> +               qcom,tcs-config = <SLEEP_TCS   3>,
>> +                                 <WAKE_TCS    3>,
>> +                                 <ACTIVE_TCS  2>,
>> +                                 <CONTROL_TCS 1>;
>> +       };