linux-kernel - [RFC] perf record: dead code perf_event__synthesize_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBTm+9Wsa21GVXpogWUDNkpRF4eyZOPGa8QJCvdV2Lz2rA@mail.gmail.com>
Date:   Wed, 02 May 2018 16:38:33 +0000
From:   Stephane Eranian <eranian@...gle.com>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>, mingo@...e.hu,
        Peter Zijlstra <peterz@...radead.org>
Subject: [RFC] perf record: dead code perf_event__synthesize_id_index()

Hi,

It looks like perf_event__synthesize_id_index() is dead code in the current
tip
tree. I don't see any invocation of the function anywhere in perf.I
understand why
you'd want to keep the rest of the code related to  PERF_RECORD_ID_INDEX
because some perf.data file may have this user-level record type. But the
synthesize code is not needed anymore, in my opinion.

Shouldn't we remove this code?