linux-kernel - Re: [PATCH] f2fs: fix the way to wake up issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ecda55f-1975-2797-41e4-eb72b492dcc3@huawei.com>
Date:   Thu, 3 May 2018 15:57:29 +0800
From:   Yunlong Song <yunlong.song@...wei.com>
To:     <jaegeuk@...nel.org>, <chao@...nel.org>, <yuchao0@...wei.com>,
        <yunlong.song@...oud.com>
CC:     <miaoxie@...wei.com>, <bintian.wang@...wei.com>,
        <shengyong1@...wei.com>, <heyunlei@...wei.com>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] f2fs: fix the way to wake up issue_flush thread

Please avoid this patch, I make a mistake.

On 2018/5/3 15:45, Yunlong Song wrote:
> Commit 6f890df0 ("f2fs: fix out-of-order execution in f2fs_issue_flush")
> uses waitqueue_active to wake up issue_flush thread, but there is no
> wait entry to wake in this queue, so change it back to use the original
> fcc->dispatch_list to wake up issue_flush thread.
>
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
> ---
>   fs/f2fs/segment.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 503a98a..5aa5ee4e 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -612,7 +612,7 @@ int f2fs_issue_flush(struct f2fs_sb_info *sbi, nid_t ino)
>   	/* update issue_list before we wake up issue_flush thread */
>   	smp_mb();
>   
> -	if (waitqueue_active(&fcc->flush_wait_queue))
> +	if (!fcc->dispatch_list)
>   		wake_up(&fcc->flush_wait_queue);
>   
>   	if (fcc->f2fs_issue_flush) {

-- 
Thanks,
Yunlong Song