[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <44871995.YYHkG5ofpC@amdc3058>
Date: Fri, 04 May 2018 12:48:46 +0200
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To: Randy Dunlap <rdunlap@...radead.org>,
Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc: Anders Roxell <anders.roxell@...aro.org>, tomi.valkeinen@...com,
linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend
on OF
On Thursday, May 03, 2018 08:48:56 AM Randy Dunlap wrote:
> On 04/20/2018 04:25 AM, Anders Roxell wrote:
> > Commit 7378f1149884 ("media: omap2: omapfb: allow building it with
> > COMPILE_TEST") broke compilation without CONFIG_OF selected.
> > CC drivers/video/fbdev/core/fbmem.o
> > drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c: In function ‘omapdss_update_prop’:
> > drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c:68:2: error: implicit declaration of function ‘of_update_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration]
> > of_update_property(node, prop);
> > ^~~~~~~~~~~~~~~~~~
> > of_get_property
> > cc1: some warnings being treated as errors
> > scripts/Makefile.build:312: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o' failed
> > make[7]: *** [drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o] Error 1
> > scripts/Makefile.build:559: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss' failed
> > make[6]: *** [drivers/video/fbdev/omap2/omapfb/dss] Error 2
> > make[6]: *** Waiting for unfinished jobs....
> >
> > Add OF dependency in order to make all configurations work again.
> >
> > of_update_property() has no inline stub, and that that could be added as
> > an alternative.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> > ---
> > drivers/video/fbdev/omap2/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig
> > index 82008699d253..4de381f2452e 100644
> > --- a/drivers/video/fbdev/omap2/Kconfig
> > +++ b/drivers/video/fbdev/omap2/Kconfig
> > @@ -1,4 +1,4 @@
> > -if ARCH_OMAP2PLUS || COMPILE_TEST
> > +if OF && (ARCH_OMAP2PLUS || COMPILE_TEST)
> >
> > source "drivers/video/fbdev/omap2/omapfb/Kconfig"
> >
> >
>
> Hi,
>
> This patch certainly fixes the build errors that I have been seeing in
> linux-next for several days now, so:
>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> Tested-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
Since there has been no follow up from Mauro on this ([1]) I guess
that the best thing I can do is simply merging both patches to fbdev
tree..
[1] https://www.spinics.net/lists/linux-media/msg132583.html
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Powered by blists - more mailing lists