linux-kernel - Re: [PATCH] bpf: fix possible spectre-v1 in find_and_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180504104927.qp4rwx6fuomdihov@lakrids.cambridge.arm.com>
Date:   Fri, 4 May 2018 11:49:28 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Peter Zijlstra <peterz@...radead.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] bpf: fix possible spectre-v1 in find_and_alloc_map()

On Fri, May 04, 2018 at 02:16:31AM +0200, Daniel Borkmann wrote:
> On 05/03/2018 06:04 PM, Mark Rutland wrote:
> > It's possible for userspace to control attr->map_type. Sanitize it when
> > using it as an array index to prevent an out-of-bounds value being used
> > under speculation.
> > 
> > Found by smatch.
> > 
> > Signed-off-by: Mark Rutland <mark.rutland@....com>
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Dan Carpenter <dan.carpenter@...cle.com>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: netdev@...r.kernel.org
> 
> Applied to bpf tree, thanks Mark!

Cheers!

> I've also just submitted one for BPF progs
> (http://patchwork.ozlabs.org/patch/908385/) which is same situation.

That looks good to me. That case doesn't show up in my smatch results so
far, but I might just need a few more build iterations.

Thanks,
Mark.