linux-kernel - Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180507.233028.1636992030271398967.davem@davemloft.net>
Date:   Mon, 07 May 2018 23:30:28 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mdf@...nel.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        alex.williams@...com
Subject: Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac
 address

From: Moritz Fischer <mdf@...nel.org>
Date: Fri,  4 May 2018 10:18:33 -0700

> Fix issue where nixge_get_nvmem_address() returns a non-NULL
> return value on a failed nvmem_cell_get() that causes an invalid
> access when error value encoded in pointer is dereferenced.
> 
> Furthermore ensure that buffer allocated by nvmem_cell_read()
> actually gets kfreed() if the function succeeds.
> 
> Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for
> National Instruments XGE netdev")
> Reported-by: Alex Williams <alex.williams@...com>
> Signed-off-by: Moritz Fischer <mdf@...nel.org>

Applied.