linux-kernel - Re: [PATCH 2/2] net: nixge: Address compiler warnings about signedness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180507.233035.1288287836007018606.davem@davemloft.net>
Date:   Mon, 07 May 2018 23:30:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mdf@...nel.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        alex.williams@...com
Subject: Re: [PATCH 2/2] net: nixge: Address compiler warnings about
 signedness

From: Moritz Fischer <mdf@...nel.org>
Date: Fri,  4 May 2018 10:18:34 -0700

> Fixes the following warnings:
> warning: pointer targets in passing argument 1 of
> ‘is_valid_ether_addr’ differ in signedness [-Wpointer-sign]
>   if (mac_addr && is_valid_ether_addr(mac_addr)) {
>                                       ^~~~~~~~
> expected ‘const u8 * {aka const unsigned char *}’ but argument
> is of type ‘const char *’
>  static inline bool is_valid_ether_addr(const u8 *addr)
>                     ^~~~~~~~~~~~~~~~~~~
> warning: pointer targets in passing argument 2 of
> ‘ether_addr_copy’ differ in signedness [-Wpointer-sign]
>    ether_addr_copy(ndev->dev_addr, mac_addr);
>                                    ^~~~~~~~
> expected ‘const u8 * {aka const unsigned char *}’ but argument
> is of type ‘const char *’
>  static inline void ether_addr_copy(u8 *dst, const u8 *src)
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>

Applied.