linux-kernel - Re: [PATCH] perf annotate: Display multiple events for --stdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f78244e-2945-d526-5db0-776fc1f562ce@linux.intel.com>
Date:   Thu, 10 May 2018 08:49:28 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf annotate: Display multiple events for --stdio



On 5/10/2018 1:24 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, May 09, 2018 at 01:42:51PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, May 09, 2018 at 11:57:15PM +0800, Jin Yao escreveu:
>>> When we perform following command lines:
>>>
>>> perf record -e "{cycles,branches}" ./div
>>> perf annotate main --stdio
>>>
>>> Only shows one event "cycles" and the displaying format is not correct.
>>>
>>>   Percent         |      Source code & Disassembly of div for cycles (44550 samples)
>>> -----------------------------------------------------------------------------------
>>
>> Please indent command output (two spaces before all lines) to avoid
>> scripts breaking due to mistaking lines starting with --- as the end of
>> the patch.
>>
>> Applying.
> 
> Also you forgot to add this:
> 
> Cc: Jiri Olsa <jolsa@...nel.org>
> Fixes: f681d593d1ce ("perf annotate: Remove disasm__calc_percent() from disasm_line__print()")
> 
> Which I've just added, to help with stable@ processing.
> 
> - Arnaldo
> 

Actually I notice this issue during fixing another issue. :)

Another issue is, without using group, the multiple events can't be 
supported well in perf annotate.

perf record -e cycles,branches ./div
perf annotate main --stdio

It should show both cycles and branches on the left side but actually it 
only show cycles.

I will post patches for fixing this (working on the patch now).

Thanks
Jin Yao