linux-kernel - Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h8neqp7g.fsf@concordia.ellerman.id.au>
Date:   Fri, 11 May 2018 23:47:15 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Kees Cook <keescook@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Yury Norov <ynorov@...iumnetworks.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly

Kees Cook <keescook@...omium.org> writes:

> On Wed, May 9, 2018 at 4:43 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
>> From: Matthew Wilcox <mawilcox@...rosoft.com>
>>
>> I had neglected to increment the error counter when the tests failed,
>> which made the tests noisy when they fail, but not actually return an
>> error code.
>>
>> Reported-by: Michael Ellerman <mpe@...erman.id.au>
>> Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
>> Fixes: 3cc78125a081 ("lib/test_bitmap.c: add optimisation tests")
>> Cc: stable@...r.kernel.org # v4.13+
>> Tested-by: Michael Ellerman <mpe@...erman.id.au>
>
> FWIW:
>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Thanks.

cheers