linux-kernel - Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87efiiqp5f.fsf@concordia.ellerman.id.au>
Date:   Fri, 11 May 2018 23:48:28 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, mawilcox@...rosoft.com,
        ynorov@...iumnetworks.com, andriy.shevchenko@...ux.intel.com,
        geert@...ux-m68k.org, keescook@...omium.org,
        torvalds@...ux-foundation.org
Subject: Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly

Andrew Morton <akpm@...ux-foundation.org> writes:
> On Wed,  9 May 2018 21:43:28 +1000 Michael Ellerman <mpe@...erman.id.au> wrote:
>> From: Matthew Wilcox <mawilcox@...rosoft.com>
>> 
>> I had neglected to increment the error counter when the tests failed,
>> which made the tests noisy when they fail, but not actually return an
>> error code.
>> 
>> Reported-by: Michael Ellerman <mpe@...erman.id.au>
>> Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
>> Fixes: 3cc78125a081 ("lib/test_bitmap.c: add optimisation tests")
>> Cc: stable@...r.kernel.org # v4.13+
>> Tested-by: Michael Ellerman <mpe@...erman.id.au>
>
> I'll add your SOB to my copy of this, as you were on the patch delivery path.

Ah yep, I wasn't on the original delivery path, but you're right I am now.

Thanks for fixing it up.

cheers