linux-kernel - Re: [PATCH 04/20] arm-nommu: use generic dma_noncoherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73603c68-da05-22bd-efab-d0387a98225d@huawei.com>
Date:   Fri, 11 May 2018 14:56:16 +0100
From:   John Garry <john.garry@...wei.com>
To:     Christoph Hellwig <hch@....de>, <iommu@...ts.linux-foundation.org>
CC:     <linux-arch@...r.kernel.org>, <linux-xtensa@...ux-xtensa.org>,
        "Michal Simek" <monstr@...str.eu>,
        Vincent Chen <deanbo422@...il.com>,
        <linux-c6x-dev@...ux-c6x.org>, <linux-parisc@...r.kernel.org>,
        <linux-sh@...r.kernel.org>, <linux-hexagon@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-m68k@...ts.linux-m68k.org>,
        <openrisc@...ts.librecores.org>, Greentime Hu <green.hu@...il.com>,
        <linux-alpha@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <nios2-dev@...ts.rocketboards.org>,
        <linux-snps-arc@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 04/20] arm-nommu: use generic dma_noncoherent_ops

On 11/05/2018 08:59, Christoph Hellwig wrote:
> Switch to the generic noncoherent direct mapping implementation for
> the nommu dma map implementation.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  arch/arc/Kconfig                |   1 +
>  arch/arm/Kconfig                |   4 +
>  arch/arm/mm/dma-mapping-nommu.c | 139 +++++---------------------------
>  3 files changed, 23 insertions(+), 121 deletions(-)
>
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index 89d47eac18b2..3a492a9aeaad 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -9,6 +9,7 @@
>  config ARC
>  	def_bool y
>  	select ARC_TIMERS
> +	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>  	select ARCH_HAS_SYNC_DMA_FOR_CPU
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE

I guess that this arc change is here by accident, no? And isn't 
ARCH_HAS_SYNC_DMA_FOR_DEVICE already selected (by 3/20)?

>  	select ARCH_HAS_SG_CHAIN
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index c43f5bb55ac8..76ddd0064f87 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig