linux-kernel - Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic be full string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180512132732.792468da@gandalf.local.home>
Date:   Sat, 12 May 2018 13:27:32 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Clark Williams <williams@...hat.com>,
        Karim Yaghmour <karim.yaghmour@...rsys.com>,
        Brendan Gregg <bgregg@...flix.com>,
        Joel Fernandes <joelaf@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-rt-users@...r.kernel.org
Subject: Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter
 logic be full string

On Sat, 12 May 2018 21:40:29 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:


> >  static int regex_match_full(char *str, struct regex *r, int len)
> >  {
> > -	if (strncmp(str, r->pattern, len) == 0)
> > -		return 1;
> > -	return 0;
> > +	/* len means str is dynamic and ends with '\0' */  
>            ^^^
>           !len (or len == 0)?
> 
> Thank you,
> 

Yes, agreed. Thanks for the review!

-- Steve