linux-kernel - Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic be full string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKQ1sVPS_rKYUVRRAU-zHKZqCNBKamBoHdHyhXOV+Ckifm1Jbw@mail.gmail.com>
Date:   Sat, 12 May 2018 20:32:18 +0200
From:   Yann Ylavic <ylavic.dev@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Clark Williams <williams@...hat.com>,
        Karim Yaghmour <karim.yaghmour@...rsys.com>,
        Brendan Gregg <bgregg@...flix.com>,
        Joel Fernandes <joelaf@...gle.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-rt-users@...r.kernel.org
Subject: Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic
 be full string

On Fri, May 11, 2018 at 9:49 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
[]
>
>  static int regex_match_front(char *str, struct regex *r, int len)
>  {
> -       if (len < r->len)
> +       if (len && len < r->len)
>                 return 0;
>
> -       if (strncmp(str, r->pattern, r->len) == 0)
> -               return 1;
> -       return 0;
> +       return strncmp(str, r->pattern, len) == 0;

strncmp(..., r->len) still?

>  }

Regards,
Yann.