linux-kernel - Re: [PATCH] mtd: nand: Add support for reading ooblayout from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1526146969.1594.0@smtp.crapouillou.net>
Date:   Sat, 12 May 2018 19:42:49 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        David Woodhouse <dwmw2@...radead.org>,
        linux-mtd@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        Boris Brezillon <boris.brezillon@...in.com>,
        Marek Vasut <marek.vasut@...il.com>
Subject: Re: [PATCH] mtd: nand: Add support for reading ooblayout from device
 tree



>>  >>  My motivation is to get rid of this (move it to devicetree):
>>  >>
>>  >> 
>> https://elixir.bootlin.com/linux/latest/source/arch/mips/jz4740/board-qi_lb60.c#L93
>>  >>  And enable the support of other boards with custom OOB layouts.
>>  >
>>  > Can you list the different layouts you have? I'm pretty sure 
>> there's a
>>  > pattern. Maybe we can even deduce the layout from the page size 
>> or OOB
>>  > size.
>> 
>>  This is the other layout I have for another ingenic device:
>>  
>> http://projects.qi-hardware.com/index.php/p/qi-kernel/source/tree/od-2011-09-18/arch/mips/jz4740/board-a320.c#L125
>> 
>>  Page size and OOB size are the same between these two devices.
> 
> Indeed. Do you know if there are other kind of layouts in the wild?

I'm getting a new board in a few weeks, I'll be able to check that out.

> Note that <layout-id> can be a string, so if each each board is
> defining its own layout, you could specify the board name here.
> Otherwise, if you just have those 2 patterns, you can just name them
> "contiguous" and "interleaved".

I don't like the idea of adding board-specific data inside the driver...
I'd prefer to use the method I used in this patch, but inside the
jz4740-nand driver, if you're OK with it.

Thanks,
-Paul