linux-kernel - Re: [PATCH] vsprintf: Fix memory barriers of ptr_key to have_filed_random_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwwyxG_7+vJ_7xAxTA_MpYQYPaZk7SYu+s8a9kafQaVmA@mail.gmail.com>
Date:   Tue, 15 May 2018 16:10:53 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        tcharding <me@...in.cc>
Subject: Re: [PATCH] vsprintf: Fix memory barriers of ptr_key to have_filed_random_ptr_key

On Tue, May 15, 2018 at 4:00 PM Steven Rostedt <rostedt@...dmis.org> wrote:

> If it is that if statement you don't like. We can get rid of it. On
> early boot, the code is called from preemptable context, it's only
> later that it is not. So we know when we can call it directly and when
> we need to have a work queue.

Oh, that looks much better to me, yes. Just doing it this way instead
removes my "ugh, that's nasty" objections.

So ack on this last version of the patch, because it doesn't scare me (or
you've worn me down ;)

               Linus