linux-kernel - Re: [PATCH net-next] net: ethernet: ti: cpsw-phy-sel: check bus_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <623a9ea1-3caa-3eeb-718b-e1e82fbfa87f@ti.com>
Date:   Tue, 15 May 2018 18:11:49 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Sekhar Nori <nsekhar@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw-phy-sel: check
 bus_find_device() ret value



On 05/15/2018 06:07 PM, Andy Shevchenko wrote:
> On Wed, May 16, 2018 at 2:01 AM, Grygorii Strashko
> <grygorii.strashko@...com> wrote:
>> This fixes klockworks warnings: Pointer 'dev' returned from call to
>> function 'bus_find_device' at line 179 may be NULL and will be dereferenced
>> at line 181.
> 
>> +               dev_err(dev, "unable to find platform device for %s\n",
>> +                       of_node_full_name(node));
> 
> Sorry, isn't %pOF works for this?
> 

Thanks, will update.

-- 
regards,
-grygorii