[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <tip-173af2613efdc29547718848a0a2928a26b1398f@git.kernel.org>
Date: Mon, 14 May 2018 23:25:21 -0700
From: tip-bot for SeongJae Park <tipbot@...or.com>
To: linux-tip-commits@...r.kernel.org
Cc: akpm@...ux-foundation.org, hpa@...or.com, will.deacon@....com,
sj38.park@...il.com, linux-kernel@...r.kernel.org,
mingo@...nel.org, peterz@...radead.org, paulmck@...ux.vnet.ibm.com,
tglx@...utronix.de, torvalds@...ux-foundation.org
Subject: [tip:locking/core] locking/Documentation: Use `warning` RST
directive
Commit-ID: 173af2613efdc29547718848a0a2928a26b1398f
Gitweb: https://git.kernel.org/tip/173af2613efdc29547718848a0a2928a26b1398f
Author: SeongJae Park <sj38.park@...il.com>
AuthorDate: Mon, 14 May 2018 15:55:33 -0700
Committer: Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 15 May 2018 08:11:15 +0200
locking/Documentation: Use `warning` RST directive
Use the proper RST directive, pointed out by a build warning.
Signed-off-by: SeongJae Park <sj38.park@...il.com>
Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Will Deacon <will.deacon@....com>
Cc: akiyks@...il.com
Cc: boqun.feng@...il.com
Cc: dhowells@...hat.com
Cc: j.alglave@....ac.uk
Cc: linux-arch@...r.kernel.org
Cc: luc.maranget@...ia.fr
Cc: npiggin@...il.com
Cc: parri.andrea@...il.com
Cc: stern@...land.harvard.edu
Link: http://lkml.kernel.org/r/1526338533-6044-8-git-send-email-paulmck@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
Documentation/core-api/atomic_ops.rst | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
index 4ea4af71e68a..2e7165f86f55 100644
--- a/Documentation/core-api/atomic_ops.rst
+++ b/Documentation/core-api/atomic_ops.rst
@@ -466,10 +466,12 @@ Like the above, except that these routines return a boolean which
indicates whether the changed bit was set _BEFORE_ the atomic bit
operation.
-WARNING! It is incredibly important that the value be a boolean,
-ie. "0" or "1". Do not try to be fancy and save a few instructions by
-declaring the above to return "long" and just returning something like
-"old_val & mask" because that will not work.
+
+.. warning::
+ It is incredibly important that the value be a boolean, ie. "0" or "1".
+ Do not try to be fancy and save a few instructions by declaring the
+ above to return "long" and just returning something like "old_val &
+ mask" because that will not work.
For one thing, this return value gets truncated to int in many code
paths using these interfaces, so on 64-bit if the bit is set in the
Powered by blists - more mailing lists