linux-kernel - Re: [PATCH net-next 0/3] net: Allow more drivers with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90022a6e-a6a7-fbfc-2d31-9f7d7bbd19a7@gmail.com>
Date:   Wed, 16 May 2018 11:18:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, andrew@...n.ch,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] net: Allow more drivers with COMPILE_TEST

On 05/16/2018 11:17 AM, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 16 May 2018 14:15:14 -0400 (EDT)
> 
>> From: Florian Fainelli <f.fainelli@...il.com>
>> Date: Tue, 15 May 2018 16:48:22 -0700
>>
>>> This patch series includes more drivers to be build tested with COMPILE_TEST
>>> enabled. This helps cover some of the issues I just ran into with missing
>>> a driver *sigh*.
>>
>> Thank you for doing this.
>>
>> Series applied.
> 
> Actually, I have to revert.
> 
> The FEC driver cannot be built tested without the appropriate platform
> specific register set defines and x86-64 for example won't provide that.

Ah, yes, it built okay for ARM 32-bit, let me fix that.

> 
> drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_restart’:
> drivers/net/ethernet/freescale/fec_main.c:959:26: error: ‘FEC_RACC’ undeclared (first use in this function); did you mean ‘FEC_RXIC0’?
>    val = readl(fep->hwp + FEC_RACC);
>                           ^~~~~~~~
>                           FEC_RXIC0
> drivers/net/ethernet/freescale/fec_main.c:959:26: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/freescale/fec_main.c:968:38: error: ‘FEC_FTRL’ undeclared (first use in this function); did you mean ‘FEC_ECNTRL’?
>    writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
>                                       ^~~~~~~~
>                                       FEC_ECNTRL
>  ...
> 


-- 
Florian