Message-ID: <AA01D623-B3ED-446C-B7C4-37856A185A4B@amperecomputing.com>
Date:   Thu, 17 May 2018 16:46:56 +0000
From:   Hoan Tran <hoan.tran@...erecomputing.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     Phil Edworthy <phil.edworthy@...esas.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Hoan Tran <hotran@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Michel Pollet <michel.pollet@...renesas.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A
 GPIO

Hi Lee,

On 5/16/18, 11:25 PM, "Lee Jones" <lee.jones@...aro.org> wrote:

    On Wed, 16 May 2018, Hoan Tran wrote:
    
    > Hi Phil,
    > 
    > On 5/11/18, 1:31 AM, "Phil Edworthy" <phil.edworthy@...esas.com> wrote:
    > 
    >     The DesignWare GPIO IP can be configured for either 1 interrupt or 1
    >     per GPIO in port A, but the driver currently only supports 1 interrupt.
    >     See the DesignWare DW_apb_gpio Databook description of the
    >     'GPIO_INTR_IO' parameter.
    >     
    >     This change allows the driver to work with up to 32 interrupts, it will
    >     get as many interrupts as specified in the DT 'interrupts' property.
    >     It doesn't do anything clever with the different interrupts, it just calls
    >     the same handler used for single interrupt hardware.
    >     
    >     Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>
    >     Reviewed-by: Rob Herring <robh@...nel.org>
    >     Acked-by: Lee Jones <lee.jones@...aro.org>
    >     ---
    >     One point to mention is that I have made it possible for users to have
    >     unconnected interrupts by specifying holes in the list of interrupts. This is
    >     done by supporting the interrupts-extended DT prop.
    >     However, I have no use for this and had to hack some test case for this.
    >     Perhaps the driver should support 1 interrupt or all GPIOa as interrupts?
    >     
    >     v6:
    >      - Treat DT and ACPI the same as much as possible. Note that we can't use
    >        platform_get_irq() to get the DT interrupts as they are in the port
    >        sub-node and hence do not have an associated platform device.
    >     v5:
    >      - Rolled ACPI companion code provided by Hoan Tran into this patch.
    >     v4:
    >      - Use of_irq_get() instead of of_irq_parse_one()+irq_create_of_mapping()
    >     v3:
    >      - Rolled mfd: intel_quark_i2c_gpio fix into this patch to avoid bisect problems
    >     v2:
    >      - Replaced interrupt-mask DT prop with support for the interrupts-extended
    >        prop. This means replacing the call to irq_of_parse_and_map() with calls
    >        to of_irq_parse_one() and irq_create_of_mapping().
    >     ---
    >      .../devicetree/bindings/gpio/snps-dwapb-gpio.txt   |  9 +++-
    >      drivers/gpio/gpio-dwapb.c                          | 49 +++++++++++++++-------
    >      drivers/mfd/intel_quark_i2c_gpio.c                 |  3 +-
    >      include/linux/platform_data/gpio-dwapb.h           |  3 +-
    >      4 files changed, 45 insertions(+), 19 deletions(-)
    >     
    >     diff --git a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
    >     index 4a75da7..3c1118b 100644
    >     --- a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
    >     +++ b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
    >     @@ -26,8 +26,13 @@ controller.
    >        the second encodes the triger flags encoded as described in
    >        Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
    >      - interrupt-parent : The parent interrupt controller.
    >     -- interrupts : The interrupt to the parent controller raised when GPIOs
    >     -  generate the interrupts.
    >     +- interrupts : The interrupts to the parent controller raised when GPIOs
    >     +  generate the interrupts. If the controller provides one combined interrupt
    >     +  for all GPIOs, specify a single interrupt. If the controller provides one
    >     +  interrupt for each GPIO, provide a list of interrupts that correspond to each
    >     +  of the GPIO pins. When specifying multiple interrupts, if any are unconnected,
    >     +  use the interrupts-extended property to specify the interrupts and set the
    >     +  interrupt controller handle for unused interrupts to 0.
    >      - snps,nr-gpios : The number of pins in the port, a single cell.
    >      - resets : Reset line for the controller.
    >      
    > Acked-by: Hoan Tran <hoan.tran@...erecomputing.com>
    
    Well that's new.  I've never seen a mailer reply like that before.
    
    Which mailer are you using?  Might be worth sorting that out.

Yes, it looks like my new email from outlook does not have the correct format. With my old one, it works correctly.

Thanks
Hoan
    
    -- 
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    

Powered by blists - more mailing lists