linux-kernel - Re: [PATCH net] tls: don't use stack memory in a scatterlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180517.164252.466789510812778167.davem@davemloft.net>
Date:   Thu, 17 May 2018 16:42:52 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mmullins@...com
Cc:     netdev@...r.kernel.org, davejwatson@...com,
        linux-kernel@...r.kernel.org, aviadye@...lanox.com, doronrk@...com
Subject: Re: [PATCH net] tls: don't use stack memory in a scatterlist

From: Matt Mullins <mmullins@...com>
Date: Thu, 17 May 2018 20:28:46 +0000

> On Thu, 2018-05-17 at 14:50 -0400, David Miller wrote:
>> I'm surprised this problem wasn't discovered sooner.  How exactly did you
>> discover it?  Did you actually see it trigger or is this purely from code
>> inspection?
> 
> Honestly, I'm not sure how it got uncovered, but it was observed at
> runtime.  Doron Roberts-Kedes hit a null pointer dereference so we
> turned on CONFIG_DEBUG_SG -- then it became a proper
> BUG_ON(!virt_addr_valid(buf)); in sg_set_buf.

Fair enough, thanks for the info.