linux-kernel - Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhRXGATOiAf1pFT5jJvDEgNHkChwZvoQri5=F7wDTQT_2A@mail.gmail.com>
Date:   Thu, 17 May 2018 20:29:23 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Richard Guy Briggs <rgb@...hat.com>
Cc:     Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Eric Paris <eparis@...hat.com>,
        Steve Grubb <sgrubb@...hat.com>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters

On Thu, May 17, 2018 at 1:20 PM, Richard Guy Briggs <rgb@...hat.com> wrote:
> Enable fork.c compilation with audit disabled.
>
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot.  Can you squash it
> down if you haven't merged it yet?

See my comment in the original patch.  I would just recommend
squashing this into the original patch the next time you post it.

> ---
>  kernel/fork.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
>         p->start_time = ktime_get_ns();
>         p->real_start_time = ktime_get_boot_ns();
>         p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
>         p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */
>         cgroup_fork(p);
>  #ifdef CONFIG_NUMA
>         p->mempolicy = mpol_dup(p->mempolicy);
> --
> 1.8.3.1

-- 
paul moore
www.paul-moore.com