linux-kernel - Re: [PATCH v2 2/3] perf report: Use perf_evlist_forced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2079e88e-7c15-9589-3ce8-9fe831bf60f1@linux.intel.com>
Date:   Fri, 18 May 2018 15:21:53 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2 2/3] perf report: Use perf_evlist_forced_leader to
 support '--group'



On 5/18/2018 3:04 PM, Jiri Olsa wrote:
> On Fri, May 18, 2018 at 08:57:39PM +0800, Jin Yao wrote:
>> Since we have created a new function perf_evlist_forced_leader,
>> so now remove the old code and use perf_evlist_forced_leader
>> instead.
>>
>> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
>> ---
>>   tools/perf/builtin-report.c | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
>> index 4c931af..63fe776 100644
>> --- a/tools/perf/builtin-report.c
>> +++ b/tools/perf/builtin-report.c
>> @@ -202,12 +202,8 @@ static int hist_iter__branch_callback(struct hist_entry_iter *iter,
> 
> there's comment in this place, which no longer applies in here:
> 
> 
> /*
>   * Events in data file are not collect in groups, but we still want
>   * the group display. Set the artificial group and set the leader's
>   * forced_leader flag to notify the display code.
>   */
> 
> could you please move/change/apply it to perf_evlist_forced_leader
> 
> thanks,
> jirka
> 

Oh, yes, I should move the comment to perf_evlist_forced_leader.

I will do it in next version.

Thanks
Jin Yao

>>   static void setup_forced_leader(struct report *report,
>>   				struct perf_evlist *evlist)
> 
>>   {
>> -	if (report->group_set && !evlist->nr_groups) {
>> -		struct perf_evsel *leader = perf_evlist__first(evlist);
>> -
>> -		perf_evlist__set_leader(evlist);
>> -		leader->forced_leader = true;
>> -	}
>> +	if (report->group_set)
>> +		perf_evlist_forced_leader(evlist);
>>   }
>>   
>>   static int process_feature_event(struct perf_tool *tool,
>> -- 
>> 2.7.4
>>