[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <90f9c7c6-b7ae-9e23-3e15-eec44ba39703@arm.com>
Date: Mon, 21 May 2018 11:15:13 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Sudeep Holla <sudeep.holla@....com>,
Jeremy Linton <jeremy.linton@....com>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
Hanjun Guo <hanjun.guo@...aro.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Will Deacon <Will.Deacon@....com>,
Catalin Marinas <Catalin.Marinas@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Rutland <Mark.Rutland@....com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-riscv@...ts.infradead.org,
Xiongfeng Wang <wangxiongfeng2@...wei.com>,
vkilari@...eaurora.org, Al Stone <ahs3@...hat.com>,
Dietmar.Eggemann@....com, Morten.Rasmussen@....com,
Palmer Dabbelt <palmer@...ive.com>,
Len Brown <lenb@...nel.org>,
John Garry <john.garry@...wei.com>, austinwc@...eaurora.org,
tnowicki@...iumnetworks.com, jhugo@...eaurora.org,
Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache
properties early
On 21/05/18 10:27, Sudeep Holla wrote:
>
>
> On 18/05/18 22:50, Andy Shevchenko wrote:
>> On Thu, May 17, 2018 at 6:47 PM, Sudeep Holla <sudeep.holla@....com> wrote:
>>
>>> Is below patch does what you were looking for ?
>>
>> Somewhat.
>> See below for some minors.
>>
>
> Thanks
>
>>> of_property_read_u64 searches for a property in a device node and read
>>> a 64-bit value from it. Instead of using of_get_property to get the
>>> property and then read 64-bit value using of_read_number, we can make
>>> use of of_property_read_u64.
>>
>> Suggested-by?
>>
>
> Yes indeed, added it locally after I sent out this patch. Will send out
> a proper patch soon.
>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>>
>>
>>> - cache_size = of_get_property(np, propname, NULL);
>>> - if (cache_size)
>>> - this_leaf->size = of_read_number(cache_size, 1);
>>> + if (!of_property_read_u64(np, propname, &cache_size))
>>> + this_leaf->size = cache_size;
>>
>> I suppose it's something like this
>>
>> ret = of_property_...(..., &this_leaf->VAR);
>> if (ret)
>> warning / set default / etc
>
> OK, I do prefer this but once I was told not to use structure elements
> directly like that, but should be harmless in this particular case, will
> do so.
>
I spoke too early, I need to retain local u64 variable otherwise we get
incompatible pointer type(expected 'u64 *' but argument is of type
‘unsigned int *’) error with Werror=incompatible-pointer-types.
--
Regards,
Sudeep
Powered by blists - more mailing lists