linux-kernel - Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 May 2018 19:26:53 +0300
From:   Andrey Ryabinin <aryabinin@...tuozzo.com>
To:     David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        "open list:KASAN" <kasan-dev@...glegroups.com>
Subject: Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot



On 05/22/2018 01:07 PM, David Hildenbrand wrote:
> Using module_init() is wrong. E.g. ACPI adds and onlines memory before
> our memory notifier gets registered.
> 
> This makes sure that ACPI memory detected during boot up will not
> result in a kernel crash.
> 
> Easily reproducable with QEMU, just specify a DIMM when starting up.

         reproducible
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---

Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug")
Acked-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc: <stable@...r.kernel.org>

>  mm/kasan/kasan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c
> index 53564229674b..a8b85706e2d6 100644
> --- a/mm/kasan/kasan.c
> +++ b/mm/kasan/kasan.c
> @@ -892,5 +892,5 @@ static int __init kasan_memhotplug_init(void)
>  	return 0;
>  }
>  
> -module_init(kasan_memhotplug_init);
> +core_initcall(kasan_memhotplug_init);
>  #endif
>