[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ff21c6e7-cb32-60d8-abd3-dfc6be3d05f7@redhat.com>
Date: Tue, 22 May 2018 18:36:49 +0200
From: David Hildenbrand <david@...hat.com>
To: Andrey Ryabinin <aryabinin@...tuozzo.com>, linux-mm@...ck.org,
Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org,
Alexander Potapenko <glider@...gle.com>,
Dmitry Vyukov <dvyukov@...gle.com>,
"open list:KASAN" <kasan-dev@...glegroups.com>
Subject: Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot
On 22.05.2018 18:26, Andrey Ryabinin wrote:
>
>
> On 05/22/2018 01:07 PM, David Hildenbrand wrote:
>> Using module_init() is wrong. E.g. ACPI adds and onlines memory before
>> our memory notifier gets registered.
>>
>> This makes sure that ACPI memory detected during boot up will not
>> result in a kernel crash.
>>
>> Easily reproducable with QEMU, just specify a DIMM when starting up.
>
> reproducible
>>
>> Signed-off-by: David Hildenbrand <david@...hat.com>
>> ---
>
> Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug")
> Acked-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
> Cc: <stable@...r.kernel.org>
Think this even dates back to:
786a8959912e ("kasan: disable memory hotplug")
>
>> mm/kasan/kasan.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c
>> index 53564229674b..a8b85706e2d6 100644
>> --- a/mm/kasan/kasan.c
>> +++ b/mm/kasan/kasan.c
>> @@ -892,5 +892,5 @@ static int __init kasan_memhotplug_init(void)
>> return 0;
>> }
>>
>> -module_init(kasan_memhotplug_init);
>> +core_initcall(kasan_memhotplug_init);
>> #endif
>>
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists