linux-kernel - Re: [PATCH] ring-buffer: Fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180522205924.0f4781eb@gandalf.local.home>
Date:   Tue, 22 May 2018 20:59:24 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ring-buffer: Fix typo in comment

On Tue, 22 May 2018 20:55:57 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 18 May 2018 22:31:28 +0200
> Vasyl Gomonovych <gomonovych@...il.com> wrote:
> 
> > Fix typo in the words 'reserved', 'been'  
> 
> Thanks, but someone sent me a bunch of spelling fixes for that file
> which included these. I'll be pushing that to linux-next soon.

I stand corrected. ring_buffer.c was fixed, but the "been" typo in
ring_buffer.h was not. I'll add that part of this patch.

-- Steve
> 
> > 
> > Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> > ---
> >  include/linux/ring_buffer.h | 2 +-
> >  kernel/trace/ring_buffer.c  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/ring_buffer.h b/include/linux/ring_buffer.h
> > index 7d9eb39fa76a..aa500da87f2a 100644
> > --- a/include/linux/ring_buffer.h
> > +++ b/include/linux/ring_buffer.h
> > @@ -63,7 +63,7 @@ void *ring_buffer_event_data(struct ring_buffer_event *event);
> >  
> >  /*
> >   * ring_buffer_discard_commit will remove an event that has not
> > - *   ben committed yet. If this is used, then ring_buffer_unlock_commit
> > + *   been committed yet. If this is used, then ring_buffer_unlock_commit
> >   *   must not be called on the discarded event. This function
> >   *   will try to remove the event from the ring buffer completely
> >   *   if another event has not been written after it.
> > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> > index dcf1c4dd3efe..a8a8eb23c489 100644
> > --- a/kernel/trace/ring_buffer.c
> > +++ b/kernel/trace/ring_buffer.c
> > @@ -2776,7 +2776,7 @@ rb_reserve_next_event(struct ring_buffer *buffer,
> >   * @buffer: the ring buffer to reserve from
> >   * @length: the length of the data to reserve (excluding event header)
> >   *
> > - * Returns a reseverd event on the ring buffer to copy directly to.
> > + * Returns a reserved event on the ring buffer to copy directly to.
> >   * The user of this interface will need to get the body to write into
> >   * and can use the ring_buffer_event_data() interface.
> >   *  
>