linux-kernel - Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hmuwqpjdd.wl-tiwai@suse.de>
Date:   Wed, 23 May 2018 15:54:54 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Guenter Roeck" <groeck@...gle.com>
Cc:     "Liam Girdwood" <lgirdwood@...il.com>,
        <alsa-devel@...a-project.org>,
        "Guenter Roeck" <groeck@...omium.org>,
        "Chintan Patel" <chintan.m.patel@...el.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

On Tue, 22 May 2018 18:58:42 +0200,
Guenter Roeck wrote:
> 
> +struct skl_dfw_v4_module_caps {
> +	u32 set_params:2;
> +	u32 rsvd:30;
> +	u32 param_id;
> +	u32 caps_size;
> +	u32 caps[HDA_SST_CFG_MAX];
> +};

Missing __packed attribute?

And I'm wondering whether we should move these definitions to uapi
headers.


thanks,

Takashi