linux-kernel - Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTf4GhycxC6TNyigS6YyiLXbZK=DHpP2Wzhw7405xVB3BA@mail.gmail.com>
Date:   Wed, 23 May 2018 09:29:46 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
        Guenter Roeck <groeck@...omium.org>,
        "Patel, Chintan M" <chintan.m.patel@...el.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility
 with v4 topology files

On Wed, May 23, 2018 at 6:54 AM Takashi Iwai <tiwai@...e.de> wrote:

> On Tue, 22 May 2018 18:58:42 +0200,
> Guenter Roeck wrote:
> >
> > +struct skl_dfw_v4_module_caps {
> > +     u32 set_params:2;
> > +     u32 rsvd:30;
> > +     u32 param_id;
> > +     u32 caps_size;
> > +     u32 caps[HDA_SST_CFG_MAX];
> > +};

> Missing __packed attribute?


Yes and no. The original structure (see
sound/soc/intel/skylake/skl-tplg-interface.h
in v4.5.y and earlier) doesn't have the __packed attribute either. I guess
it doesn't hurt,
since it is all u32, so I'll add it in.

Guenter

> And I'm wondering whether we should move these definitions to uapi
> headers.


> thanks,

> Takashi