linux-kernel - Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180525085614.6cdfb484@xps13>
Date:   Fri, 25 May 2018 08:56:14 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine
 compat need

Hi Robert,

On Thu, 24 May 2018 20:07:11 +0200, Robert Jarzmik
<robert.jarzmik@...e.fr> wrote:

> Miquel Raynal <miquel.raynal@...tlin.com> writes:
> 
> > Hi Robert,  
> 
> Actually, a last time error slipped in this patch here (I'm really doing poorly
> on the copy paste side):
> +	nfc->dma_chan =	dma_request_slave_channel(&nfc->dev, "data");
> 
> This should rather be :
> +	nfc->dma_chan =	dma_request_slave_channel(nfc->dev, "data");
> 
> Would you grant your ack for the next iteration with this change folded in ?

Didn't spot it. But, sure, I'm okay with the changes :)

Thanks,
Miquèl